RFR: 8283782: Redundant verification of year in LocalDate::ofEpochDay [v2]
Claes Redestad
redestad at openjdk.java.net
Tue Mar 29 14:07:41 UTC 2022
On Tue, 29 Mar 2022 13:56:09 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Sparse out the range of offsets tested
>
> test/jdk/java/time/test/java/time/TestLocalDate.java line 432:
>
>> 430: long minYear = ChronoField.YEAR.range().getMinimum();
>> 431: long maxYear = ChronoField.YEAR.range().getMinimum();
>> 432: for (int i = 0; i < 500; i++) {
>
> The 500 seems like it would burn a lot of cycles mostly redundant.
> How about { 1, 2, 3, 28, 29, 30, 31, 32, 363, 364, 365, 366, 367}.
Yes, makes sense to avoid useless work. Added 0 to the list.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8014
More information about the core-libs-dev
mailing list