RFR: 8283782: Redundant verification of year in LocalDate::ofEpochDay [v3]
Claes Redestad
redestad at openjdk.java.net
Tue Mar 29 15:27:28 UTC 2022
> In `LocalDate::ofEpochDays` we validate the epoch day input, then we also validate the year derived from that value. This second validation is redundant since the minimum and maximum valid epoch day line up with the first and last day of the minimum and maximum valid year, respectively. This patch replace this redundant runtime validation with a test.
>
> This reduces code complexity (increasing chance for inlining to happen) and removes a couple of branches from generated code.
Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
typo: to -> of
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8014/files
- new: https://git.openjdk.java.net/jdk/pull/8014/files/44a11aa7..ef0ca1b3
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8014&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8014&range=01-02
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/8014.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/8014/head:pull/8014
PR: https://git.openjdk.java.net/jdk/pull/8014
More information about the core-libs-dev
mailing list