RFR: 8284950: CgroupV1 detection code should consider memory.swappiness [v14]
Severin Gehwolf
sgehwolf at openjdk.java.net
Tue May 3 14:43:18 UTC 2022
On Tue, 3 May 2022 13:38:07 GMT, xpbob <duke at openjdk.java.net> wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>> Memory & Swap Limit: 100.00M
>> Maximum Processes Limit: 4194305
>>
>> =>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>> Memory & Swap Limit: 50.00M
>> Maximum Processes Limit: 4194305
>
> xpbob has updated the pull request incrementally with one additional commit since the last revision:
>
> revert file
This looks much better. Thanks!
test/hotspot/jtreg/containers/docker/TestMemoryWithCgroupV1.java line 52:
> 50: return;
> 51: }
> 52: if ("cgroupv1".equals(metrics.getProvider())) {
Consider adding a an `else` clause with something like:
`System.out.println("Memory swappiness not supported with cgroups v2. Test skipped.");`
test/hotspot/jtreg/containers/docker/TestMemoryWithCgroupV1.java line 78:
> 76:
> 77: OutputAnalyzer out = Common.run(opts);
> 78: System.out.println(out.getOutput());
This looks like debug output?
-------------
PR: https://git.openjdk.java.net/jdk/pull/8285
More information about the core-libs-dev
mailing list