RFR: 8277090 : jsr166 refresh for jdk19 [v2]

[Paul Sandoz]

On Mon, 2 May 2022 13:33:33 GMT, Doug Lea <dl at openjdk.org> wrote:

>> This is the jsr166 refresh for jdk19. See https://bugs.openjdk.java.net/browse/JDK-8285450 and https://bugs.openjdk.java.net/browse/JDK-8277090
>
> Doug Lea has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

Looks good, although I cannot say i reviewed the fork join pool code as thoroughly, since it is particularly difficult, so i was most looking for consistency in the pattern of code.

src/java.base/share/classes/java/util/concurrent/ForkJoinWorkerThread.java line 76:

> 74:     ForkJoinWorkerThread(ThreadGroup group, ForkJoinPool pool,
> 75:                          boolean useSystemClassLoader,
> 76:                          boolean clearThreadLocals) {

It's tempting to toggle the sense of last boolean argument to be `preserveThreadLocals` for consistency (given the multiple toggles as the value is propagated from the newly added protected constructor), but which means toggling the value at the use sites that you may not wish to change.

-------------

Marked as reviewed by psandoz (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8490