RFR: 8284950: CgroupV1 detection code should consider memory.swappiness [v15]
Severin Gehwolf
sgehwolf at openjdk.java.net
Wed May 4 09:22:11 UTC 2022
On Wed, 4 May 2022 01:37:27 GMT, xpbob <duke at openjdk.java.net> wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>> Memory & Swap Limit: 100.00M
>> Maximum Processes Limit: 4194305
>>
>> =>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>> Memory & Swap Limit: 50.00M
>> Maximum Processes Limit: 4194305
>
> xpbob has updated the pull request incrementally with one additional commit since the last revision:
>
> update code
src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 154:
> 152: log_trace(os, container)("Memory and Swap Limit has been reset to " JULONG_FORMAT " because swappiness is 0", memlimit);
> 153: return memlimit;
> 154: }
It now occurs to me that we'd need the same treatment of this on line `143`. Perhaps extract a function and call it in both places?
-------------
PR: https://git.openjdk.java.net/jdk/pull/8285
More information about the core-libs-dev
mailing list