RFR: JDK-8285497: Add system property for Java SE specification maintenance version [v7]
Mark Reinhold
mr at openjdk.java.net
Thu May 5 21:33:54 UTC 2022
On Wed, 4 May 2022 23:10:06 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> Add a new system property, java.specification.maintenance.version, to return the maintenance release number of the Java SE specification being implemented. The property is unset, optional in the terminology of System.getProperties, for an initial release of a specification.
>>
>> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764
>>
>> I'll update copyright years before an integration.
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>
> - Respond to mbreinhold review feedback.
> - Merge branch 'master' into JDK-8285497
> - Update wording to address review feedback.
> - Merge branch 'master' into JDK-8285497
> - Change punctuation from review feedback.
> - Respond to review feedback; make sequence of values explicit.
> - Respond to review feedback.
> - Respond to review feedback.
> - Respond to CSR feedback.
> - Merge branch 'master' into JDK-8285497
> - ... and 2 more: https://git.openjdk.java.net/jdk/compare/f3cf898e...7b7720cf
Changes requested by mr (Lead).
src/java.base/share/classes/java/lang/System.java line 790:
> 788: * href="https://jcp.org/en/procedures/jcp2#3.6.4">maintenance
> 789: * release</a>. When defined, its value identifies that
> 790: * maintenance release. To indicate the first maintenance release
The final sentence can be shortened, and looking at it now the semicolon should just be a comma:
* maintenance release. To indicate the first maintenance release
* this property will have the value {@code "1"}, to indicate the
* second maintenance release it will have the value {@code "2"},
* and so on.
Otherwise, this looks good to me.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8437
More information about the core-libs-dev
mailing list