RFR: 8285517: System.getenv() returns unexpected value if environment variable has non ASCII character [v2]

Ichiroh Takiguchi itakiguchi at openjdk.java.net
Fri May 6 14:33:00 UTC 2022


On Mon, 2 May 2022 15:00:07 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Ichiroh Takiguchi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8285517: System.getenv() returns unexpected value if environment variable has non ASCII character
>
> Can you clarify the use of different charset properties for the ProcessEnvironment vs the CommandLine strings?
> 
> They are used to decode or encode strings in the APIs to native functions respectively.
> If I understand `native.encoding` was introduced to reflect the default encoding of file contents, while `sun.jnu.encoding` is used to encode filenames.
> 
> I think I would have expected to see `sun.jnu.encoding` to be used in all contexts when encoding/decoding strings to the native representations.  (Assuming its not required for backward compatibility).

Hello @RogerRiggs and @naotoj .
I put sun.jnu.encoding related code into s`StaticProperty.java`.
Could you review the files again including javadoc comment ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8378


More information about the core-libs-dev mailing list