RFR: 8285097: Duplicate XML keys in XPATHErrorResources.java and XSLTErrorResources.java [v3]

Tyler Steele duke at openjdk.java.net
Fri May 6 15:02:10 UTC 2022


On Wed, 20 Apr 2022 15:48:54 GMT, Tyler Steele <duke at openjdk.java.net> wrote:

>> Shruthi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Replace the ER_RTF_NOT_SUPPORTED_XRTREEFRAGSELECTWRAPPER key in XPATHErrorResources language files
>
> src/java.xml/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources.java line 599:
> 
>> 597: 
>> 598:   { ER_ASNODEITERATOR_NOT_SUPPORTED_XRTREEFRAGSELECTWRAPPER,
>> 599:        "asNodeIterator() not supported by XRTreeFragSelectWrapper"},
> 
> For this key, please review places where the old key was used to find places where the new key was intended. I believe [this line](https://github.com/openjdk/jdk/blob/master/src/java.xml/share/classes/com/sun/org/apache/xpath/internal/objects/XRTreeFragSelectWrapper.java#L155) is an example.

[Here](https://github.com/openjdk/jdk/blob/64225e19995e81d2e836ce84befea1a01bb6c860/src/java.xml/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_de.java#L595) is another usage where the other key is intended. I expect you will find similar references in at least some of the other translation files.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8318


More information about the core-libs-dev mailing list