RFR: 8286441: Remove mode parameter from jdk.internal.perf.Perf.attach() [v2]

Alan Bateman alanb at openjdk.java.net
Wed May 11 18:12:53 UTC 2022


On Wed, 11 May 2022 02:43:21 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never supported the value `"rw"` since the source code was imported to the openjdk repo more than 15 years ago. In fact HotSpot throws `IllegalArgumentException` when such a mode is specified.
>> 
>> It's unlikely such a mode will be required for future enhancements. Support for `"rw"` is removed. The "mode" parameter is also removed, since now `"r"` is the only supported mode.
>> 
>> I also cleaned up related code in the JDK and HotSpot.
>> 
>> Testing:
>> - Passed tiers 1 and 2
>> - Tiers 3, 4, 5 are in progress
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Marked as reviewed by alanb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8622


More information about the core-libs-dev mailing list