RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe [v2]

[Alexander Matveev]

On Wed, 11 May 2022 21:58:46 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe [v2]
>
> test/jdk/tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java line 48:
> 
>> 46: 
>> 47:     @Test
>> 48:     public static void test() throws Exception {
> 
> I'd give some more descriptive names to test functions than `test` and `test2`. Something like `testWithStripNativeCommands` and `testWithoutStripNativeCommands` maybe?

Fixed.

> test/jdk/tools/jpackage/macosx/MacAppStoreRuntimeTest.java line 102:
> 
>> 100: 
>> 101:         cmd.execute(1);
>> 102:     }
> 
> @Test
> @Parameter("true")
> @Parameter("false")
> public static void test(boolean stripNativeCommands) throws Exception {
>     JPackageCommand cmd = JPackageCommand.helloAppImage();
>     cmd.addArguments("--mac-app-store", "--runtime-image", getRuntimeImage(stripNativeCommands));
> 
>     if (stripNativeCommands) {
>         cmd.executeAndAssertHelloAppImageCreated();
>     } else {
>         cmd.execute(1);
>     }
> }

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8666