RFR: 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked

[Martin Balao]

On Thu, 10 Feb 2022 15:25:09 GMT, Aleksei Efimov <aefimov at openjdk.org> wrote:

>>> The concerns are two folds:
>>> 
>>> * without a regression test, you have to trust that the source changes actually work, and there's typically no verification possible
>>> * without a regression test, the next refactoring change in this area two years from now could undo the fix and nobody would notice
>>> 
>> 
>> Thanks, that was what I initially thought but wanted to check if I was missing something else given the previous discussion. I should be able to generate a build for the user and ask him to test in his real environment. As for the other concern, I'll evaluate options and let you know.
>
>> Thanks, that was what I initially thought but wanted to check if I was missing something else given the previous discussion. I should be able to generate a build for the user and ask him to test in his real environment. As for the other concern, I'll evaluate options and let you know.
> 
> Thanks for the update, Martin.
> I'm ok with pushing the fix without a test given that the user will verify it in his real environment.
> Maybe, you could also log a bug for a test addition and describe in it an environment, and sort of a high-level scenario of how JDK-8275535 can be reproduced.

Hi @AlekseiEfimov ,

Apologies for the delay. We had no feedback from our customer. However, we released the fix in our builds and there were no regressions reported. I'll proceed with the integration of this fix.

Thanks,
Martin.-

-------------

PR: https://git.openjdk.java.net/jdk/pull/6043