RFR: 8286681: ShenandoahControlThread::request_gc misses the case of GCCause::_codecache_GC_threshold

[Jie Fu]

On Fri, 13 May 2022 06:56:23 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Without `-XX:+UseShenandoahGC`, this bug wouldn't be exposed.
>> 
>> What do you mean by `if you are testing with +ShenandoahGC then it will run already`?
>
> I assume you are running the tests with:
>    make run-tests TEST_OPTS_JAVA_OPTIONS="-XX:+UseShenandoahGC" 
> in which case, all of the tests you select to run will be run with that GC. 
> 
> What you have is not wrong but wouldn't be a better to add a new test to test/hotspot/jtreg/gc rather than relying on test in test/jdk/java/foreign?

> I think I agree with @AlanBateman - in the sense that this seems to go down a slippery slope where every test would need to be executed against all possible GCs. AFAIK, there are no other foreign tests doing this.

I think it's a waste of time to write a separate test for this bug.

I can't understand why you are against adding one more test config in the foreign test.
Yes, it caught the bug in ShenandoahGC but who knows it wouldn't find some other bugs in the foreign api in the future.
If you are still against the newly added test config, I can revert the test change.
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8691