RFR: 8282280: Update Xerces to Version 2.12.2

Naoto Sato naoto at openjdk.java.net
Mon May 16 22:01:35 UTC 2022


On Mon, 16 May 2022 19:34:11 GMT, Joe Wang <joehw at openjdk.org> wrote:

> Update to Xerces 2.12.2.
> 
> The update also fixes JDK-8144117. Added a test.
> 
> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this update. See related issue report.

Changes look good to me. Some minor nits follow.

test/jaxp/javax/xml/jaxp/unittest/validation/SchemaTest.java line 48:

> 46:  */
> 47: public class SchemaTest {
> 48:     private static final String XSD_8144117 = "<?xml version='1.0'?>\n" +

If it is not from the upstream Xerces test but our own, can we utilize text blocks here?

test/jaxp/javax/xml/jaxp/unittest/validation/SchemaTest.java line 79:

> 77: 
> 78:     /*
> 79:      * DataProvider: valid xsd

This comment is the same as the above provider. Can we change it to a more meaningful one?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8732


More information about the core-libs-dev mailing list