RFR: 8286669: Replace MethodHandle specialization with ASM in mainline [v3]
Rémi Forax
forax at openjdk.java.net
Tue May 17 06:16:54 UTC 2022
On Mon, 16 May 2022 17:40:41 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Hi,
>>
>> This PR brings over commits from the panama-foreign repo. These commits mostly pertain to the switch to ASM and away from MethodHandle combinators for the binding recipe specialization. But, there is one more commit which adds freeing of downcall stubs, since those changes were mostly Java as well.
>>
>> Thanks,
>> Jorn
>>
>> Testing: `run-test-jdk_foreign` with `-Dgenerator.sample.factor=-1` on Windows and Linux.
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>
> BootstrapMethodError -> ExceptionInInitializerError
src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java line 943:
> 941: Z, B, S, C, I, J, F, D, L;
> 942:
> 943: static BasicType of(Class<?> cls) {
This seems a duplication of ASM Type class for no good reason, Type.getOpcode(ILOAD) or Type.getOpcode(IRETURN) gives you the proper variant opcode
-------------
PR: https://git.openjdk.java.net/jdk/pull/8685
More information about the core-libs-dev
mailing list