RFR: 8286669: Replace MethodHandle specialization with ASM in mainline [v4]
openjdk-notifier[bot]
duke at openjdk.java.net
Wed May 18 09:56:58 UTC 2022
On Tue, 17 May 2022 16:22:15 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Hi,
>>
>> This PR brings over commits from the panama-foreign repo. These commits mostly pertain to the switch to ASM and away from MethodHandle combinators for the binding recipe specialization. But, there is one more commit which adds freeing of downcall stubs, since those changes were mostly Java as well.
>>
>> Thanks,
>> Jorn
>>
>> Testing: `run-test-jdk_foreign` with `-Dgenerator.sample.factor=-1` on Windows and Linux.
>
> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>
> - Merge branch 'pr/7959' into JEP-19-ASM
> - BootstrapMethodError -> ExceptionInInitializerError
> - Use unaligned layout constants when filling in reconstituted structs (was accidentally dropped change)
> - Fix LinkUpcall benchmark
> - 8286306: Upcall wrapper class sharing
>
> Reviewed-by: mcimadamore
> - Polish
> - 8281595: ASM-ify scope acquire/release for down call parameters
> 8281387: Some downcall shapes show unexpected allocations
>
> Co-authored-by: Maurizio Cimadamore <mcimadamore at openjdk.org>
> Reviewed-by: mcimadamore
> - 8281228: Preview branch's CLinker.downcallHandle crashes inside asm
>
> Reviewed-by: sundar, jvernee
> - 8278414: Replace binding recipe customization using MH combinators with bytecode spinning
>
> Reviewed-by: mcimadamore
> - 8276648: Downcall stubs are never freed
>
> Reviewed-by: mcimadamore
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:
git checkout JEP-19-ASM
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push
-------------
PR: https://git.openjdk.java.net/jdk/pull/8685
More information about the core-libs-dev
mailing list