RFR: 8284638: store skip buffers in InputStream Object [v7]
XenoAmess
duke at openjdk.java.net
Fri May 20 16:18:01 UTC 2022
On Wed, 20 Apr 2022 16:36:16 GMT, XenoAmess <duke at openjdk.java.net> wrote:
>>> no, we use other way, but yes for we take care of thread safety.
>>
>> Fair enough.
>>
>>> Don't think it necessary... I think making it cannot touched by other object (with security manager on) is enough.
>>
>> I was thinking more for heapdumps due to extending the life of the skip buffer in this patch. At least we don't have to waste more cycles.
>>
>> Oh I forgot last time but, it looks like MIN_SKIP_BUFFER_SIZE is not used. Unless I'm missing something I assume that is a bug.
>
> @jmehrens comments about not making it static added.
> @XenoAmess This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
comment.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5872
More information about the core-libs-dev
mailing list