RFR: 8286825: Linker naming cleanup [v2]

Robbin Ehn rehn at openjdk.java.net
Mon May 23 06:08:43 UTC 2022


On Fri, 20 May 2022 10:57:44 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> This patch is a batch naming cleanup for the foreign linker implementation.
>> 
>> The naming changes are as follows:
>> 
>>   - ProgrammableInvoker -> DowncallLinker
>>   - ProgrammableUpcallHandler -> UpcallLinker
>>   - 'native invoker' -> 'downcall stub'
>>   - 'optimzed entry blob' -> 'upcall stub'
>>   - OptimizedEntryBlob -> UpcallStub
>>   - optimized_entry_frame -> upcall_stub_frame
>> 
>> Then renaming of some hotspot files:
>> 
>>   - universalNativeInvoker* -> downcallLinker*
>>   - universalUpcallHandler* -> upcallLinker*
>>   - foreign_globals* -> foreignGlobals* (to match existing convention)
>>   
>> Method, field, and other variable names are also adjusted accordingly.
>> 
>> Testing: Tier 1-4
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Comments + cleanup

Note that some find downcall/upcall unintuitive.
We may need revisit this.

Thanks

-------------

Marked as reviewed by rehn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8777


More information about the core-libs-dev mailing list