RFR: 8284199: Implementation of Structured Concurrency (Incubator) [v2]

[Maurizio Cimadamore]

On Tue, 24 May 2022 10:44:39 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Use {@code ...}, replace task->subtask, fix typos, add jls ref
>>  - Merge
>>  - @ignore StructuredThreadDumpTest until test infra in place
>>  - Refresh
>>  - Merge
>>  - Initial commit
>
> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/StructuredTaskScope.java line 1110:
> 
>> 1108:          * invoked {@link #join() join} (or {@link #joinUntil(Instant) joinUntil}).
>> 1109:          * The behavior of this method is unspecified when invoking this method before
>> 1110:          * the {@code join} is invoked.
> 
> Suggestion:
> 
>          * {@link #join} is invoked.

More generally, I see that you used `{@code ... }` in a lot of places where `{@link ... }` could also be used. In some of those places (like this one) where there is a clear cross-reference, I think `@link` could be preferrable. The only case where `@code` is fine is when referring to the name of the class itself (e.g. `{@code StructuredTaskScope}`). But of course this is subjective.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8787