RFR: 8284638: store skip buffers in InputStream Object [v12]
XenoAmess
duke at openjdk.java.net
Tue May 24 20:32:33 UTC 2022
On Fri, 20 May 2022 21:08:51 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add documents
>
> src/java.base/share/classes/java/io/InputStream.java line 72:
>
>> 70: *
>> 71: * @param size minimum length that the skip byte array must have.
>> 72: * notice that this param input MUST be equal or less than {@link #MAX_SKIP_BUFFER_SIZE MAX_SKIP_BUFFER_SIZE}.
>
> The "MUST be equal" reads like something will go wrong if that condition isn't satisfied.
> This method does not care about the size, except in potentially resizing if the requested size is larger.
>
> The "notice..." statement is making a statement about code in the caller, and so doesn't belong here.
The "notice..." statement removed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5872
More information about the core-libs-dev
mailing list