RFR: 8287244: Add bound check in indexed memory access var handle [v3]

Jorn Vernee jvernee at openjdk.java.net
Wed May 25 13:51:02 UTC 2022


On Tue, 24 May 2022 18:15:45 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Constructing indexed var handles using the `MemoryLayout` API produces `VarHandle` which do not check the input indices for out-of-bounds conditions.
>> While this can never result in a VM crash (after all the memory segment will protect against "true" OOB access), it is still possible for an access expression to refer to parts of a segment that are logically unrelated.
>> 
>> This patch adds a "logical" bound check to all indexed var handles generated using the layout API.
>> Benchmarks are not affected by the check. Users are still able to create custom "unchecked" var handles, using the combinator API in `MethodHandles`.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

Very nice!

-------------

Marked as reviewed by jvernee (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8868


More information about the core-libs-dev mailing list