RFR: 8287292: Improve TransformKey to pack more kinds of transforms efficiently [v2]

[Jorn Vernee]

On Wed, 25 May 2022 14:03:41 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> The bespoke caching scheme in `jl.invoke.LambdaFormEditor.TransformKey` allows keys to be compacted when all byte values of the key fit in 4 bits, otherwise a byte array is allocated and used. This means that all transforms with a kind value above 15 will be forced to allocate and use array comparisons.
>> 
>> Removing unused and folding some transforms to ensure all existing kinds can fit snugly within the 0-15 value range realize a minor improvement to footprint, speed and allocation pressure of affected transforms, e.g. ~300bytes/op reduction in the `StringConcatFactoryBootstraps` microbenchmark:
>> 
>> Baseline:
>> 
>> Benchmark                                                      Mode  Cnt     Score     Error   Units
>> SCFB.makeConcatWithConstants                                   avgt   15  2048.475 ?  69.887   ns/op
>> SCFB.makeConcatWithConstants:?gc.alloc.rate.norm               avgt   15  3487.311 ?  80.385    B/op
>> 
>> 
>> Patched:
>> 
>> Benchmark                                                      Mode  Cnt     Score     Error   Units
>> SCFB.makeConcatWithConstants                                   avgt   15  1961.985 ? 101.519   ns/op
>> SCFB.makeConcatWithConstants:?gc.alloc.rate.norm               avgt   15  3156.478 ? 183.600    B/op
>
> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments, fix unsafe shift, rework and remove ofBothArrays

Marked as reviewed by jvernee (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8881