RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller [v3]
Severin Gehwolf
sgehwolf at openjdk.java.net
Wed May 25 15:53:20 UTC 2022
On Wed, 25 May 2022 08:40:48 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> If you don't like the `default:` coding style, how about this:
>>
>>
>> switch (info.getName()) {
>> // Only the following controllers are important to Java. All
>> // other controllers (such as freezer) are ignored and
>> // are not considered in the checks below for
>> // anyCgroupsV1Controller/anyCgroupsV1Controller.
>> case CPU_CTRL: infos.put(CPU_CTRL, info); break;
>> case CPUACCT_CTRL: infos.put(CPUACCT_CTRL, info); break;
>> case CPUSET_CTRL: infos.put(CPUSET_CTRL, info); break;
>> case MEMORY_CTRL: infos.put(MEMORY_CTRL, info); break;
>> case BLKIO_CTRL: infos.put(BLKIO_CTRL, info); break;
>> case PIDS_CTRL: infos.put(PIDS_CTRL, info); break;
>> }
>
> It confused me, fwiw. Anyway up to you. It's not super important.
works for me. +1. Note the typo `anyCgroupsV1Controller/anyCgroupsV2Controller` not **V1** twice.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8858
More information about the core-libs-dev
mailing list