RFR: 8287064: Modernize ProxyGenerator.PrimitiveTypeInfo [v3]

Mandy Chung mchung at openjdk.java.net
Fri May 27 00:01:37 UTC 2022


On Thu, 26 May 2022 23:35:10 GMT, liach <duke at openjdk.java.net> wrote:

>> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 969:
>> 
>>> 967:             // single-char BaseType descriptor (see JVMS section 4.3.2)
>>> 968:             String baseTypeString = wrapper.basicTypeString();
>>> 969:             wrapperClassName = dotToSlash(wrapper.wrapperType().getName());
>> 
>> Suggestion:
>> 
>>             wrapperClassName = wrapper.wrapperType().descriptorString();
>> 
>> 
>> It may worth to replace similar use of `dotToSlash(c.getName())` pattern.
>
> Unfortunately, we want an internal name (`xxx/Abc`) than a field descriptor (`Lxxx/Abc;`). But we can use descriptor string for the valueOf descriptor construction.

ah, you're right.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8801


More information about the core-libs-dev mailing list