RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v14]

[Brian Burkhalter]

On Tue, 31 May 2022 17:07:06 GMT, Raffaello Giulietti <duke at openjdk.java.net> wrote:

>> Hello,
>> 
>> here's a PR for a patch submitted on March 2020 [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a thing.
>> 
>> The patch has been edited to adhere to OpenJDK code conventions about multi-line (block) comments. Nothing in the code proper has changed, except for the addition of redundant but clarifying parentheses in some expressions.
>> 
>> 
>> Greetings
>> Raffaello
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   4511638: Double.toString(double) sometimes produces incorrect results

src/java.base/share/classes/jdk/internal/math/MathUtils.java line 38:

> 36:      *
> 37:      *     Giulietti, "The Schubfach way to render doubles",
> 38:      *     https://drive.google.com/file/d/1gp5xv4CAa78SVgCeWfGqqI4FfYYYuNFb

Even though not public, should the reference use the `<cite/>` tag and perhaps be in a `@see` annotation?

@see <a href=“https://drive.google.com/file/d/1gp5xv4CAa78SVgCeWfGqqI4FfYYYuNFb”>
     <cite>The Schubfach way to render doubles</cite></a>

src/java.base/share/classes/jdk/internal/math/MathUtils.java line 193:

> 191:      */
> 192:     private static final long[] g = {
> 193:         /* -324 */ 0x4F0C_EDC9_5A71_8DD4L, 0x5B01_E8B0_9AA0_D1B5L,

Not significant, but might this be clearer instead to comment the array elements on the right?

    0x4F0C_EDC9_5A71_8DD4L, 0x5B01_E8B0_9AA0_D1B5L, // -324

-------------

PR: https://git.openjdk.java.net/jdk/pull/3402