RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v14]

[Brian Burkhalter]

On Tue, 31 May 2022 17:07:06 GMT, Raffaello Giulietti <duke at openjdk.java.net> wrote:

>> Hello,
>> 
>> here's a PR for a patch submitted on March 2020 [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a thing.
>> 
>> The patch has been edited to adhere to OpenJDK code conventions about multi-line (block) comments. Nothing in the code proper has changed, except for the addition of redundant but clarifying parentheses in some expressions.
>> 
>> 
>> Greetings
>> Raffaello
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   4511638: Double.toString(double) sometimes produces incorrect results

src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java line 97:

> 95:     private static final int MASK_28 = (1 << 28) - 1;
> 96: 
> 97:     private static final int NON_SPECIAL    = 0;

Would these constants be better as an enum?

src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java line 118:

> 116:     private int index;
> 117: 
> 118:     private DoubleToDecimal() {

Maybe add a comment like

    /**
     * Prevent instantiation.
     */

or

// Prevent instantiation of this class.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3402