RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v14]
Brian Burkhalter
bpb at openjdk.java.net
Tue May 31 22:29:54 UTC 2022
On Tue, 31 May 2022 17:07:06 GMT, Raffaello Giulietti <duke at openjdk.java.net> wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020 [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about multi-line (block) comments. Nothing in the code proper has changed, except for the addition of redundant but clarifying parentheses in some expressions.
>>
>>
>> Greetings
>> Raffaello
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
>
> 4511638: Double.toString(double) sometimes produces incorrect results
src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java line 72:
> 70: static final int E_MAX = 309;
> 71:
> 72: /* Threshold to detect tiny values, as in section 8.2.1 of [1] */
Comments like this one pointing to specific places in the Schubfach paper are very helpful in understanding the constants and the various steps in the algorithm.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3402
More information about the core-libs-dev
mailing list