RFR: JDK-8292427: Improve specification of InflaterInputStream.fill()

Alan Bateman alanb at openjdk.org
Wed Nov 2 17:21:28 UTC 2022


On Wed, 2 Nov 2022 12:37:26 GMT, Lance Andersen <lancea at openjdk.org> wrote:

> Hi all,
> 
> This PR will update the javadoc to clarify the existing behavior of InflaterInputStream::fill as it currently omits the possibility that a EOFException may be thrown and that the protected `len` field is also updated by this method.

src/java.base/share/classes/java/util/zip/InflaterInputStream.java line 258:

> 256:      *            unexpectedly
> 257:      * @apiNote
> 258:      * The {@link #len} field will be updated when this method is invoked.

I don't think an apiNote will work here as it need to be normative text. I suspect this issue will require specifying fill to read up to buf.length bytes into buf starting at element 0 and setting len to the number of bytes.

-------------

PR: https://git.openjdk.org/jdk/pull/10945


More information about the core-libs-dev mailing list