RFR: JDK-8292427: Improve specification of InflaterInputStream.fill() [v4]

Alan Bateman alanb at openjdk.org
Wed Nov 2 20:14:39 UTC 2022


On Wed, 2 Nov 2022 19:11:32 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Hi all,
>> 
>> This PR will update the javadoc to clarify the existing behavior of InflaterInputStream::fill as it currently omits the possibility that a EOFException may be thrown and that the protected `len` field is also updated by this method.
>
> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change buffer to input buffer

src/java.base/share/classes/java/util/zip/InflaterInputStream.java line 256:

> 254:      * This method will read up to {@link #buf}.length bytes into the input
> 255:      * buffer, {@link #buf}, starting at element {@code 0}. The {@link #len}
> 256:      * field will be set to the number of bytes read.

Thanks for the update, this wording looks okay, I'm just wondering if we should add implSpec as "This method will read ..." is really "Implementation Specification".

-------------

PR: https://git.openjdk.org/jdk/pull/10945


More information about the core-libs-dev mailing list