RFR: 8294982: Implementation of Classfile API

Adam Sotona asotona at openjdk.org
Mon Nov 7 13:05:30 UTC 2022


On Mon, 7 Nov 2022 12:13:08 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> This is root pull request with Classfile API implementation, tests and benchmarks initial drop into JDK.
>> 
>> Following pull requests consolidating JDK class files parsing, generating, and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) will chain to this one.
>> 
>> Classfile API development is tracked at:
>> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-branch
>> 
>> Development branch of consolidated JDK class files parsing, generating, and transforming is at:
>> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-dev-branch
>> 
>> Classfile API [JEP](https://bugs.openjdk.org/browse/JDK-8280389) and [online API documentation](https://htmlpreview.github.io/?https://raw.githubusercontent.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/jdk/classfile/package-summary.html) is also available.
>> 
>> Please take you time to review this non-trivial JDK addition.
>> 
>> Thank you,
>> Adam
>
> make/modules/java.base/Java.gmk line 37:
> 
>> 35: 
>> 36: EXCLUDES += java/lang/doc-files
>> 37: EXCLUDES += jdk/classfile/snippets
> 
> I don't like hard-coded excludes like this. Is this the first real-world example of snippets in the JDK? If not, how has this been resolved in other instances? Maybe we need a more general method to exclude snippets from compiling.

I'll fix it, thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/10982


More information about the core-libs-dev mailing list