RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly [v3]
Aleksei Efimov
aefimov at openjdk.org
Tue Nov 8 00:27:00 UTC 2022
On Mon, 7 Nov 2022 20:39:27 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Thanks for spotting that, Jai.
>> You're correct that in its current version the fix changed an old logic of `doUdpQuery`/`query` methods:
>> Before this change the method was returning `null` not when a receive is timed out but when an unmatched packet is received. Socket timeout exceptions thrown by `DatagramSocket.receive` were caught in `query` method.
>> After the proposed change the `doUdpQuery` method is throwing `SocketTimeoutException` for both cases (timeout and unmatched packets) - that needs to be changed to comply with old logic. Will address it in an upcoming changeset.
>
> This is addressed now - right?
Yes, already addressed in 55dd0a4
-------------
PR: https://git.openjdk.org/jdk/pull/11007
More information about the core-libs-dev
mailing list