RFR: 8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160" [v3]

Roger Riggs rriggs at openjdk.org
Wed Nov 9 21:13:33 UTC 2022


On Tue, 11 Oct 2022 20:50:15 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> On Windows, suppress failure if the total space indicated by `df` is less than `FileStore::getTotalSpace` and the free space indicated by `df` equals `FileStore::getUnallocatedSpace`.
>
> Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - 8291911: Minor formatting cleanup in test
>  - Merge
>  - 8291911: work in progress
>  - 8291911: Account for quotas on Windows.
>  - 8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160"

Looks fine.

test/jdk/java/io/File/GetXSpace.java line 140:

> 138:         StringBuilder sb = new StringBuilder();
> 139:         Process p = Runtime.getRuntime().exec(cmd);
> 140:         try (BufferedReader in = new BufferedReader(new InputStreamReader(p.getInputStream()))) {

The RHS could be replaced by `p.inputReader()`.  (new in JDK 17)

-------------

Marked as reviewed by rriggs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9856


More information about the core-libs-dev mailing list