RFR: JDK-8262435: Clarify the behavior of a few inherited ZipInputStream methods
Jaikiran Pai
jpai at openjdk.org
Thu Nov 10 18:47:28 UTC 2022
On Mon, 7 Nov 2022 09:55:52 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Please review the following PR which updates several of the ZipInputStream methods whose javadoc is inherited to clarify the methods are acting on the current ZIP Entry.
>>
>> There are no changes in behavior. The main description for the method's javadoc that has been copied has been clarified and the remaining doc is the same.
>
> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 210:
>
>> 208: * Reads all remaining bytes from the input stream for the current ZIP entry.
>> 209: * This method blocks until all remaining bytes have been read and end of
>> 210: * stream is detected, or an exception is thrown. This method does not close
>
> Hello Lance, the part where it says that it reads the current ZIP entry sounds fine. However, this also states that it will wait until the end of stream is detected. Should we make it clearer by changing this to say `This method blocks until all remaining bytes of the entry have been read or an exception is thrown`?
Similar comment for the other `readNBytes` and skip methods.
-------------
PR: https://git.openjdk.org/jdk/pull/10995
More information about the core-libs-dev
mailing list