RFR: JDK-8262435: Clarify the behavior of a few inherited ZipInputStream methods [v4]
Lance Andersen
lancea at openjdk.org
Mon Nov 14 18:16:51 UTC 2022
On Mon, 14 Nov 2022 11:08:25 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 179:
>>
>>> 177: * {@link #closeEntry()} has been called, otherwise always return 1.
>>> 178: * I think it will need to say that input stream for the current ZIP entry has been read to end of stream, or the
>>> 179: * ZIP entry has been closed with closeEntry
>>
>> A comment from the PR has been pasted here :-)
>> Ignoring that, the updated description for the "available" method looks okay but might be clearer to say that closeEntry has been called on the current entry.
>
>> A comment from the PR has been pasted here :-)
>> Ignoring that, the updated description for the "available" method looks okay but might be clearer to say that closeEntry has been called on the current entry.
>
> whoops, fixed :-)
I just went and added the extra wording regarding the "current entry". I did not add it originally because the verbiage links to closeEntry which indicates that it closes the current entry and thought it might be overkill
-------------
PR: https://git.openjdk.org/jdk/pull/10995
More information about the core-libs-dev
mailing list