RFR: JDK-8262435: Clarify the behavior of a few inherited ZipInputStream methods [v7]

Brian Burkhalter bpb at openjdk.org
Mon Nov 14 21:05:56 UTC 2022


On Mon, 14 Nov 2022 20:03:24 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Please review the following PR which updates several of the ZipInputStream methods whose javadoc is inherited to clarify the methods  are acting on  the current ZIP Entry.
>> 
>> There are no changes in behavior.  The main description for the method's javadoc that has been copied has been clarified and the remaining doc is the same.
>
> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove always from  available()

src/java.base/share/classes/java/util/zip/ZipInputStream.java line 30:

> 28: import java.io.EOFException;
> 29: import java.io.IOException;
> 30: import java.io.InputStream;

Nitpick: should the `InputStream` import precede that of `IOException`?

src/java.base/share/classes/java/util/zip/ZipInputStream.java line 178:

> 176:      * Returns 0 when end of stream is detected for the current ZIP entry or
> 177:      * {@link #closeEntry()} has been called on the current ZIP entry, otherwise
> 178:      * return 1.

Another nitpick: should this be `returns 1` to match `Returns 0` at line 176? Or vice versa?

-------------

PR: https://git.openjdk.org/jdk/pull/10995


More information about the core-libs-dev mailing list