RFR: 8296329: jar validator doesn't account for minor class file version [v2]

Bo Zhang duke at openjdk.org
Wed Nov 16 00:44:50 UTC 2022


> As described in [JDK-8296329](https://bugs.openjdk.org/browse/JDK-8296329), previously, the jar validator compare the "version" to validate a multi-release jar. The "version" is a mix of the major and minor version fused into a single int, which might be a negative number with `--enable-preview` - this result in wrong comparison.
> 
> This PR fixes it by only comparing major versions.

Bo Zhang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  8296329: Only compare major versions in jar validator

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11153/files
  - new: https://git.openjdk.org/jdk/pull/11153/files/93ec7fb8..b293cbfe

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11153&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11153&range=00-01

  Stats: 30 lines in 1 file changed: 13 ins; 4 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/11153.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11153/head:pull/11153

PR: https://git.openjdk.org/jdk/pull/11153


More information about the core-libs-dev mailing list