RFR: JDK-8297215: Update libs tests to use @enablePreview [v2]

Joe Darcy darcy at openjdk.org
Fri Nov 18 18:45:03 UTC 2022


On Fri, 18 Nov 2022 08:28:22 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to review feedback.
>
> test/jdk/java/lang/Thread/BuilderTest.java line 29:
> 
>> 27:  * @enablePreview
>> 28:  * @compile BuilderTest.java
>> 29:  * @run testng/othervm BuilderTest
> 
> I assume `@compile` can be dropped from most of these tests now. Also I think /othervm can be dropped too because jtreg will always use othervm for tests that require --enable-preview. When the feature becomes permanent then it would mean dropping the `@enablePreview` tag, no other changes.

Right; ideally when the feature becomes non-preview the test update would just be removing the "@enablePreview" line. I didn't author these tests so I initially left any "othervm" directives in place since they aren't incorrect, just at worst a bit inefficient.

-------------

PR: https://git.openjdk.org/jdk/pull/11222


More information about the core-libs-dev mailing list