RFR: JDK-8297299 SequenceInputStream should not use Vector [v5]
Jaikiran Pai
jpai at openjdk.org
Mon Nov 21 06:34:13 UTC 2022
On Sun, 20 Nov 2022 17:41:28 GMT, Markus KARG <duke at openjdk.org> wrote:
>> There is no need to use a temporary Vector within the constructor of SynchronizedInputStream, as more efficient (non-synchronized) alternative code (like List.of) will do the same in possibly less time. While the optimization is not dramatic, it still makes sense to replace Vector unless synchronization is really needed.
>
> Markus KARG has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>
> Jens' Proposal
Thank you Markus for the changes. The latest version in `2e957354` looks fine to me. While we are at it, would you be willing to change the member variables `e` to `private final` and the `in` to `private`? From what I can see, I don't see any other class accessing these package private fields.
-------------
PR: https://git.openjdk.org/jdk/pull/11249
More information about the core-libs-dev
mailing list