RFR: JDK-8297299 SequenceInputStream should not use Vector [v2]

Alan Bateman alanb at openjdk.org
Mon Nov 21 07:46:23 UTC 2022


On Sun, 20 Nov 2022 16:58:56 GMT, Markus KARG <duke at openjdk.org> wrote:

>> Indeed my intention solely is to get rid of `Vector`, so I am fine with keeping a low profile and being full backwards compatible. I assume SIS is seldomly used, so opening a can of warms is not worth it (I think). I am perfectly happy with your proposal, but for the sake of brevity I'd rather go with a shorter way of doing the pretty same:
>> ```this(Collections.enumeration(Arrays.asList(s1, s2)))```
>> Are we all fine with that? Otherwise I'd switch this PR back to Alan's proposal.
>
> N.B.: Regarding usage numbers, I will do a quick poll on Twitter.

> Indeed my intention solely is to get rid of `Vector`, so I am fine with keeping a low profile and being full backwards compatible. I assume SIS is seldomly used, so opening a can of warms is not worth it (I think).

If you have the cycles then collecting data on usages and finding examples where the constructor is called with a second parameter of null would be useful. It's a lot of work to do that of course. The changes in update 2e957354 look okay, I can't immediately see any behavior change with that version.

-------------

PR: https://git.openjdk.org/jdk/pull/11249


More information about the core-libs-dev mailing list