RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v2]

Sean Coffey coffeys at openjdk.org
Mon Nov 21 16:08:27 UTC 2022


On Wed, 16 Nov 2022 15:06:14 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   the change according to review comment
>
> src/java.base/share/classes/jdk/internal/util/SystemProps.java line 52:
> 
>> 50:      * @return a boolean value
>> 51:      */
>> 52:     public static boolean checkIfWarningRequired() {
> 
> I would rename the method to `checkIoTmpdir`; it will be easier to see the purpose in the call in System.

+1 I might suggest `isBadIoTmpdir` for method name

-------------

PR: https://git.openjdk.org/jdk/pull/11174


More information about the core-libs-dev mailing list