RFR: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation

Evgeny Nikitin enikitin at openjdk.org
Thu Nov 24 13:44:49 UTC 2022


On Thu, 24 Nov 2022 13:23:13 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> When concatenating Strings, OutOfMemoryError should be thrown on all overflow conditions. This fixes a case that erroneously thro IAE on concatenations of long (`length > Integer.MAX_VALUE/2`) UTF16 strings due failing to check for overflow after shifting index left with the coder.
> 
> This was caught by a fuzzer test. Added a sanity test that fails without the patch (loosely derived from ImplicitStringConcatMany.java)

LGTM.

-------------

Marked as reviewed by enikitin (Author).

PR: https://git.openjdk.org/jdk/pull/11354


More information about the core-libs-dev mailing list