RFR: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation [v2]

[Andrey Turbanov]

On Thu, 24 Nov 2022 15:01:12 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> When concatenating Strings, OutOfMemoryError should be thrown on all overflow conditions. This fixes a case that erroneously thro IAE on concatenations of long (`length > Integer.MAX_VALUE/2`) UTF16 strings due failing to check for overflow after shifting index left with the coder.
>> 
>> This was caught by a fuzzer test. Added a sanity test that fails without the patch (loosely derived from ImplicitStringConcatMany.java)
>
> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Require 64-bit arch to avoid (most) hypothetical false positives

test/jdk/java/lang/String/concat/ImplicitStringConcatOOME.java line 129:

> 127:     }
> 128: 
> 129:     public static void test(String expected, String actual) {

When this method is called?

-------------

PR: https://git.openjdk.org/jdk/pull/11354