RFR: [DRAFT] 8294982: Implementation of Classfile API

Magnus Ihse Bursie ihse at openjdk.org
Sat Nov 26 18:44:51 UTC 2022


On Fri, 25 Nov 2022 15:18:09 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> I'll fix it, thanks.
>
> Unfortunately I found only two use cases of external snippets in JDK. One is explicitly excluding the snippets package and the other does not care, so the snippets are included.

Is the practice of naming the directory `snippets` well-established or mandated? Otherwise I think a name like `snippet-files` (akin to `doc-files`) would be much better, since it indicates that is not a java package name. (These do not usually include `-`; I am unsure if this is prohibited by the specification, or just not used by convention.)

In fact, when checking, I see that there is already a handful of `snippet-files`:

./jdk.jfr/share/classes/jdk/jfr/snippet-files
./jdk.jfr/share/classes/jdk/jfr/consumer/snippet-files
./java.compiler/share/classes/javax/tools/snippet-files


So maybe rename it to `snippet-files`, and I'll look into making exclusion of `snippet-files` be done automatically.

-------------

PR: https://git.openjdk.org/jdk/pull/10982


More information about the core-libs-dev mailing list