RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v4]
Alan Bateman
alanb at openjdk.org
Mon Nov 28 14:00:41 UTC 2022
On Sat, 5 Nov 2022 00:04:39 GMT, Bill Huang <bhuang at openjdk.org> wrote:
>> The current non local registry tests require a manual process that runs rmiregitrty on a different machine and changes the -Dregistry.host property in the source before running the tests on the local machine. This task is created to improve this manual process and provide a clearer instruction to the test engineer about the test requirement.
>>
>> Tests include:
>> java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java
>> java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java
>> javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
>
> Implemented review comments.
test/jdk/javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java line 167:
> 165: Set.copyOf(Arrays.asList(InetAddress.getAllByName(myHostName)));
> 166: Set<InetAddress> hostAddrs =
> 167: Set.copyOf(Arrays.asList(InetAddress.getAllByName(host)));
Is there a reason to change this from Set.of?
-------------
PR: https://git.openjdk.org/jdk/pull/10825
More information about the core-libs-dev
mailing list