RFR: 8296645: org.openjdk.bench.javax.tools.Javac leaves class files in current directory [v2]

Jaikiran Pai jpai at openjdk.org
Tue Nov 29 06:03:33 UTC 2022


On Tue, 15 Nov 2022 13:53:23 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> $ java -jar ../build/linux-x86_64-server-release/images/test/micro/benchmarks.jar org.openjdk.bench.javax.tools.Javac.testCompile -f 1 -r 1s -w 1s
>> ...
>> 
>> $ ls
>> Apan.class
>> ``` 
>> 
>> Additional testing:
>>  - [x] Eyeballing CWD and `/tmp` contents after the benchmark -- no leftovers
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8296645-javac-bench-class-files
>  - Fix indenting
>  - Fix

Looks fine to me. The copyright year will need an update.

-------------

Marked as reviewed by jpai (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11055


More information about the core-libs-dev mailing list