RFR: JDK-8297731: Remove redundant check in MutableBigInteger.divide [v2]

Raffaello Giulietti rgiulietti at openjdk.org
Wed Nov 30 11:07:21 UTC 2022


On Tue, 29 Nov 2022 20:35:00 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Remove redundant code reported in
>> 
>> https://mail.openjdk.org/pipermail/core-libs-dev/2022-November/097163.html
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove whitespace.

I second Joe's concern: breaking invariants makes reasoning harder for future changes.

In my experience, IDEA suggestions are almost always good, but sometimes I stumbled upon the eternal human-versus-mechanical reasoning dilemma.

-------------

PR: https://git.openjdk.org/jdk/pull/11395


More information about the core-libs-dev mailing list