RFR: 8297853: windows-x86 test build broken
Jorn Vernee
jvernee at openjdk.org
Wed Nov 30 16:08:28 UTC 2022
On Wed, 30 Nov 2022 15:58:17 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> test/micro/org/openjdk/bench/java/lang/foreign/libQSortJNI.c is missing the correct macro definition to compile on 32-bit Windows.
test/micro/org/openjdk/bench/java/lang/foreign/libQSortJNI.c line 31:
> 29: #include "JNICB.h"
> 30:
> 31: #if defined(_WIN64) || defined(_WIN32)
`_WIN32` is defined on x64 as well [1], so I think this can just be `#ifdef _WIN32` to mean 'Windows'
[1]: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170
-------------
PR: https://git.openjdk.org/jdk/pull/11434
More information about the core-libs-dev
mailing list