RFR: 8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails on Japanese Windows platform [v2]

Naoto Sato naoto at openjdk.org
Mon Oct 3 17:36:30 UTC 2022


On Mon, 3 Oct 2022 16:59:40 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> At least, the results in different encodings are the same as before the fix.
>> How about not fixing the pattern for other encordings to avoid false negative?
>
> This looks good to me. The only requirement to the value of `testString` is that it is a letter outside of the Basic Latin character set. So picking a letter that can be encoded in the active encoding works.

Although I still prefer preventing possible errors in the test, the change does not make it worse than before.

-------------

PR: https://git.openjdk.org/jdk/pull/10226


More information about the core-libs-dev mailing list