RFR: 8178355: IdentityHashMap uses identity-based comparison for values everywhere except remove(K,V) and replace(K,V,V) [v6]

Stuart Marks smarks at openjdk.org
Wed Oct 5 18:11:29 UTC 2022


On Wed, 5 Oct 2022 03:40:27 GMT, liach <duke at openjdk.org> wrote:

>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare values by identity. Updated API documentation of these two methods ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Object,java.lang.Object))) to mention such behavior.
>
> liach has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Spec updates and clarifications.

OK, thanks for the updates. I've attached a specdiff and have tweaked the CSR in a few places and I've marked it reviewed. Go ahead and mark it Finalized.

(I could actually do this myself, but I'd have to reassign the CSR to myself, make it Finalized, then reassign it back to you. That would save a messaging round-trip, but it would generate more notification spam. Plus I figured I'd give you the pleasure of hitting the **Finalize** button. :-D )

-------------

PR: https://git.openjdk.org/jdk/pull/8259


More information about the core-libs-dev mailing list