RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]
Kim Barrett
kbarrett at openjdk.org
Sun Oct 9 18:00:57 UTC 2022
On Sun, 9 Oct 2022 08:17:15 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> The C99 snprintf is available with Visual Studio 2015 and above, alongside Windows 10 and the UCRT, and is no longer identical to the outdated Windows _snprintf. Since support for the Visual C++ 2017 compiler was removed a while ago, we can now safely remove the compatibility workaround on Windows and have JLI_Snprintf simply delegate to snprintf.
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>
> Comment formatting
src/java.base/share/native/libjli/jli_util.h line 91:
> 89: * https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference
> 90: * /snprintf-snprintf-snprintf-l-snwprintf-snwprintf-l?view=msvc-170
> 91: */
I don't think the comment about the *lack* of a workaround is needed, just adding clutter. But this isn't code I have much involvement with. Other than that, the change looks fine.
-------------
PR: https://git.openjdk.org/jdk/pull/10625
More information about the core-libs-dev
mailing list