RFR: 8291917: Windows - Improve error messages when the C Runtime Libraries or jvm.dll cannot be loaded [v14]

[David Holmes]

On Thu, 6 Oct 2022 12:45:08 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Please review a small patch for dumping the failure reason when the MSVCRT libraries or the Java Virtual Machine fails to load on Windows, which can provide invaluable insight when debugging related launcher issues.
>> 
>> See https://bugs.openjdk.org/browse/JDK-8292016 and the related Pull Request for the reason that the existing JLI error reporting utility was not used in this enhancement
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-4
>  - Merge branch 'openjdk:master' into patch-4
>  - Use - instead of : as a separator
>  - Merge branch 'openjdk:master' into patch-4
>  - Make DLL_ERROR4 look a little better without changing what it means
>  - Revert changes to JLI_ReportErrorMessageSys
>  - Update java_md.c
>  - Update java_md.h
>  - Merge branch 'openjdk:master' into patch-4
>  - Merge branch 'openjdk:master' into patch-4
>  - ... and 6 more: https://git.openjdk.org/jdk/compare/fe291396...c3113cac

src/java.base/windows/native/libjli/java_md.h line 48:

> 46:  */
> 47: 
> 48: void reportWithLastWindowsError(const char* message, ...);

Why does this need to be exported in the header file? Are you expecting other code to call this?

-------------

PR: https://git.openjdk.org/jdk/pull/9749